From: Ryan Lortie <desrt@desrt.ca>
Date: Sun, 16 Nov 2014 23:50:14 +0000 (-0800)
Subject: network: properly remove connections from list
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~1970
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=3d4408dce810f3b6995ed2acf28b61bed48c1dac;p=gnome-shell.git

network: properly remove connections from list

Due to a typo we were always removing the first (index 0) connection
from the global list of connections instead of the correct one.

This resulted in some connections remaining in the shell's connection
list long after they were removed.  In particular, this resulted in
multiple copies of a bluetooth connection appearing after suspend/resume
(when the device was readded and the cached connection list was
rescanned).

https://bugzilla.gnome.org/show_bug.cgi?id=740227
---

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 728584c1b..459d51dd5 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -1867,7 +1867,7 @@ const NMApplet = new Lang.Class({
     _connectionRemoved: function(connection) {
         let pos = this._connections.indexOf(connection);
         if (pos != -1)
-            this._connections.splice(connection, 1);
+            this._connections.splice(pos, 1);
 
         let section = connection._section;